Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parsing base64-encoded TUF metadata and root content #1671

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

haydentherapper
Copy link
Contributor

Because these fields are specified as objects, they can either be data.Signed{} structs when initially created, or base64-encoded strings after canonicalization and being constructed from the leaf node value.

Summary

Release Note

Documentation

Because these fields are specified as objects, they can either be
data.Signed{} structs when initially created, or base64-encoded strings
after canonicalization and being constructed from the leaf node value.

Signed-off-by: Hayden Blauzvern <[email protected]>
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #1671 (9f11592) into main (2a3bd37) will increase coverage by 0.01%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##             main    #1671      +/-   ##
==========================================
+ Coverage   66.88%   66.90%   +0.01%     
==========================================
  Files          88       88              
  Lines        8816     8850      +34     
==========================================
+ Hits         5897     5921      +24     
- Misses       2221     2227       +6     
- Partials      698      702       +4     
Flag Coverage Δ
e2etests 48.91% <53.84%> (-0.01%) ⬇️
unittests 47.64% <64.10%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/types/tuf/v0.0.1/entry.go 63.72% <69.23%> (+0.12%) ⬆️

... and 1 file with indirect coverage changes

📢 Have feedback on the report? Share it here.

@bobcallaway bobcallaway merged commit 7aa4849 into sigstore:main Sep 8, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Sep 8, 2023
@haydentherapper haydentherapper deleted the tuf-unmarshal branch September 8, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants