Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New - Included CIFuzz #1212

Closed

Conversation

naveensrinivasan
Copy link
Contributor

  • included cifuzz
  • removed the make fuzz func which was running fuzz tests.

@naveensrinivasan naveensrinivasan requested review from cpanato and a team as code owners November 19, 2022 17:09
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2022

Codecov Report

Merging #1212 (18350e3) into main (9c89f80) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1212      +/-   ##
==========================================
- Coverage   63.27%   63.22%   -0.06%     
==========================================
  Files          82       82              
  Lines        7670     7670              
==========================================
- Hits         4853     4849       -4     
- Misses       2205     2207       +2     
- Partials      612      614       +2     
Flag Coverage Δ
e2etests 47.80% <ø> (+0.02%) ⬆️
unittests 42.03% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/alpine/v0.0.1/entry.go 71.13% <0.00%> (-2.44%) ⬇️
pkg/types/rekord/v0.0.1/entry.go 68.42% <0.00%> (+0.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AdamKorcz
Copy link
Contributor

Be aware that the fuzzers currently fail at runtime which will be fixed when this lands: google/oss-fuzz#8937

It might make sense to hold CIFuzz until then. The PR should land early next week.

@naveensrinivasan
Copy link
Contributor Author

Be aware that the fuzzers currently fail at runtime which will be fixed when this lands: google/oss-fuzz#8937

It might make sense to hold CIFuzz until then. The PR should land early next week.

👍

@AdamKorcz
Copy link
Contributor

Be aware that the fuzzers currently fail at runtime which will be fixed when this lands: google/oss-fuzz#8937

It might make sense to hold CIFuzz until then. The PR should land early next week.

This has now been merged.

@naveensrinivasan naveensrinivasan requested review from bobcallaway and removed request for cpanato December 2, 2022 01:27
- included cifuzz
- removed the make fuzz func which was running fuzz tests.

Signed-off-by: naveensrinivasan <[email protected]>
Signed-off-by: naveensrinivasan <[email protected]>
Signed-off-by: naveensrinivasan <[email protected]>
@bobcallaway
Copy link
Member

we have good coverage with oss-fuzz and no need to add these as a CI check at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants