-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add algorithm registry markdown and KnownSignatureAlgorithm
enumeration
#194
Merged
woodruffw
merged 18 commits into
sigstore:main
from
trail-of-forks:alex/configurable-crypto
Jan 17, 2024
Merged
Add algorithm registry markdown and KnownSignatureAlgorithm
enumeration
#194
woodruffw
merged 18 commits into
sigstore:main
from
trail-of-forks:alex/configurable-crypto
Jan 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Cameron <[email protected]>
Signed-off-by: Alex Cameron <[email protected]>
tetsuo-cpp
commented
Jan 16, 2024
Signed-off-by: Alex Cameron <[email protected]>
ret2libc
reviewed
Jan 16, 2024
woodruffw
reviewed
Jan 16, 2024
woodruffw
reviewed
Jan 16, 2024
Signed-off-by: Alex Cameron <[email protected]>
…s registry Signed-off-by: Alex Cameron <[email protected]>
Signed-off-by: Alex Cameron <[email protected]>
Signed-off-by: Alex Cameron <[email protected]>
Signed-off-by: Alex Cameron <[email protected]>
Signed-off-by: Alex Cameron <[email protected]>
Signed-off-by: Alex Cameron <[email protected]>
Signed-off-by: Alex Cameron <[email protected]>
Signed-off-by: Alex Cameron <[email protected]>
tetsuo-cpp
changed the title
Add algorithm registry markdown and
Add algorithm registry markdown and Jan 17, 2024
SupportedAlgorithm
enumerationKnownSignatureAlgorithm
enumeration
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
woodruffw
reviewed
Jan 17, 2024
woodruffw
previously approved these changes
Jan 17, 2024
woodruffw
reviewed
Jan 17, 2024
woodruffw
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just nits on the hash chocies
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
haydentherapper
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of our work to support configurable crypto algorithms in Sigstore, we're adding both a markdown file documenting the supported algorithm combinations as well as a
SupportedAlgorithm
enumeration to support any code that operates on these algorithms.