Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified the intent of the uri field in the certificate authority #140

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Clarified the intent of the uri field in the certificate authority #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
289ea39
Clarified the intent of the uri field in the certificate authority
kommendorkapten Sep 18, 2023
e7a6d7c
Fixed spelling
kommendorkapten Sep 18, 2023
25e05b5
Generate files based on the updated protobuf files.
kommendorkapten Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gen/jsonschema/schemas/CertificateAuthority.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"uri": {
"type": "string",
"description": "The URI at which the CA can be accessed."
"description": "The URI identifies the certificate authority. It is RECOMMENDED that the URI is the base URL for the certificate authority, that can be provided to any SDK/client provided by the certificate authority to interact with the certificate authority."
},
"certChain": {
"$ref": "#/definitions/dev.sigstore.common.v1.X509CertificateChain",
Expand Down
2 changes: 1 addition & 1 deletion gen/jsonschema/schemas/Input.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@
},
"uri": {
"type": "string",
"description": "The URI at which the CA can be accessed."
"description": "The URI identifies the certificate authority. It is RECOMMENDED that the URI is the base URL for the certificate authority, that can be provided to any SDK/client provided by the certificate authority to interact with the certificate authority."
},
"certChain": {
"$ref": "#/definitions/dev.sigstore.common.v1.X509CertificateChain",
Expand Down
2 changes: 1 addition & 1 deletion gen/jsonschema/schemas/TrustedRoot.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
},
"uri": {
"type": "string",
"description": "The URI at which the CA can be accessed."
"description": "The URI identifies the certificate authority. It is RECOMMENDED that the URI is the base URL for the certificate authority, that can be provided to any SDK/client provided by the certificate authority to interact with the certificate authority."
},
"certChain": {
"$ref": "#/definitions/dev.sigstore.common.v1.X509CertificateChain",
Expand Down
7 changes: 6 additions & 1 deletion gen/pb-go/trustroot/v1/sigstore_trustroot.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion gen/pb-python/sigstore_protobuf_specs/dev/sigstore/trustroot/v1/__init__.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/pb-rust/schemas/CertificateAuthority.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"uri": {
"type": "string",
"description": "The URI at which the CA can be accessed."
"description": "The URI identifies the certificate authority. It is RECOMMENDED that the URI is the base URL for the certificate authority, that can be provided to any SDK/client provided by the certificate authority to interact with the certificate authority."
},
"certChain": {
"$ref": "#/definitions/dev.sigstore.common.v1.X509CertificateChain",
Expand Down
2 changes: 1 addition & 1 deletion gen/pb-rust/schemas/Input.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@
},
"uri": {
"type": "string",
"description": "The URI at which the CA can be accessed."
"description": "The URI identifies the certificate authority. It is RECOMMENDED that the URI is the base URL for the certificate authority, that can be provided to any SDK/client provided by the certificate authority to interact with the certificate authority."
},
"certChain": {
"$ref": "#/definitions/dev.sigstore.common.v1.X509CertificateChain",
Expand Down
2 changes: 1 addition & 1 deletion gen/pb-rust/schemas/TrustedRoot.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
},
"uri": {
"type": "string",
"description": "The URI at which the CA can be accessed."
"description": "The URI identifies the certificate authority. It is RECOMMENDED that the URI is the base URL for the certificate authority, that can be provided to any SDK/client provided by the certificate authority to interact with the certificate authority."
},
"certChain": {
"$ref": "#/definitions/dev.sigstore.common.v1.X509CertificateChain",
Expand Down
9 changes: 8 additions & 1 deletion gen/pb-typescript/src/__generated__/sigstore_trustroot.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion protos/sigstore_trustroot.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,12 @@ message CertificateAuthority {
// The root certificate MUST be self-signed, and so the subject and
// issuer are the same.
dev.sigstore.common.v1.DistinguishedName subject = 1;
// The URI at which the CA can be accessed.
// The URI identifies the certificate authority.
//
// It is RECOMMENDED that the URI is the base URL for the certificate
// authority, that can be provided to any SDK/client provided
// by the certificate authority to interact with the certificate
// authority.
string uri = 2;
// The certificate chain for this CA.
dev.sigstore.common.v1.X509CertificateChain cert_chain = 3;
Expand Down