Renamed a field based on PR feed back and clarified the comment.

Signed-off-by: Fredrik Skogman <[email protected]>
sigstore · Dec 18, 2023 · 372221b · 372221b
1 parent c26c17e
commit 372221b
Show file tree

Hide file tree

Showing 9 changed files with 98 additions and 91 deletions.
diff --git a/gen/jsonschema/schemas/ArtifactVerificationOptions.schema.json b/gen/jsonschema/schemas/ArtifactVerificationOptions.schema.json
@@ -270,9 +270,9 @@
                     "type": "boolean",
                     "description": "Disable verification for transparency logs."
                 },
-                "verifySetTimestamp": {
+                "verifySet": {
                     "type": "boolean",
-                    "description": "Verify SET timestamps indicates that the timestamp from the SET should be used when verifying the X.509 certifiacte chain"
+                    "description": "Verify SET indicates that the timestamp from the SET should be used when verifying the X.509 certifiacte chain. Note that inclusion promises (SETs) are optional in a bundle, and so requiring SET may render bundles invalid during verification if SET is not present."
                 }
             },
             "additionalProperties": false,

diff --git a/gen/jsonschema/schemas/Input.schema.json b/gen/jsonschema/schemas/Input.schema.json
@@ -770,9 +770,9 @@
                     "type": "boolean",
                     "description": "Disable verification for transparency logs."
                 },
-                "verifySetTimestamp": {
+                "verifySet": {
                     "type": "boolean",
-                    "description": "Verify SET timestamps indicates that the timestamp from the SET should be used when verifying the X.509 certifiacte chain"
+                    "description": "Verify SET indicates that the timestamp from the SET should be used when verifying the X.509 certifiacte chain. Note that inclusion promises (SETs) are optional in a bundle, and so requiring SET may render bundles invalid during verification if SET is not present."
                 }
             },
             "additionalProperties": false,

diff --git a/gen/pb-go/verification/v1/sigstore_verification.pb.go b/gen/pb-go/verification/v1/sigstore_verification.pb.go
diff --git a/gen/pb-python/sigstore_protobuf_specs/dev/sigstore/verification/v1/__init__.py b/gen/pb-python/sigstore_protobuf_specs/dev/sigstore/verification/v1/__init__.py
diff --git a/gen/pb-ruby/lib/sigstore_verification_pb.rb b/gen/pb-ruby/lib/sigstore_verification_pb.rb
diff --git a/gen/pb-rust/schemas/ArtifactVerificationOptions.schema.json b/gen/pb-rust/schemas/ArtifactVerificationOptions.schema.json
@@ -270,9 +270,9 @@
                     "type": "boolean",
                     "description": "Disable verification for transparency logs."
                 },
-                "verifySetTimestamp": {
+                "verifySet": {
                     "type": "boolean",
-                    "description": "Verify SET timestamps indicates that the timestamp from the SET should be used when verifying the X.509 certifiacte chain"
+                    "description": "Verify SET indicates that the timestamp from the SET should be used when verifying the X.509 certifiacte chain. Note that inclusion promises (SETs) are optional in a bundle, and so requiring SET may render bundles invalid during verification if SET is not present."
                 }
             },
             "additionalProperties": false,

diff --git a/gen/pb-rust/schemas/Input.schema.json b/gen/pb-rust/schemas/Input.schema.json
@@ -770,9 +770,9 @@
                     "type": "boolean",
                     "description": "Disable verification for transparency logs."
                 },
-                "verifySetTimestamp": {
+                "verifySet": {
                     "type": "boolean",
-                    "description": "Verify SET timestamps indicates that the timestamp from the SET should be used when verifying the X.509 certifiacte chain"
+                    "description": "Verify SET indicates that the timestamp from the SET should be used when verifying the X.509 certifiacte chain. Note that inclusion promises (SETs) are optional in a bundle, and so requiring SET may render bundles invalid during verification if SET is not present."
                 }
             },
             "additionalProperties": false,