Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unit tests for serialize_v0 file model #58

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

laurentsimon
Copy link
Collaborator

@laurentsimon laurentsimon commented Oct 27, 2023

Part of #57

Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
@mihaimaruseac
Copy link
Collaborator

Hmm, pytest cannot be found in the runner :(

Signed-off-by: laurentsimon <[email protected]>
@laurentsimon laurentsimon enabled auto-merge (squash) October 30, 2023 15:18
@laurentsimon laurentsimon merged commit e1d3187 into sigstore:main Oct 30, 2023
7 of 8 checks passed
@laurentsimon
Copy link
Collaborator Author

oops, I might have clicked the auto-merge and the pre-submit was not marked "required". I'm looking at the pre-submit failure and will send a PR

@mihaimaruseac
Copy link
Collaborator

I made it as required now.

@laurentsimon
Copy link
Collaborator Author

I set the pre-submits as required in settings.

@sigstore sigstore deleted a comment Dec 15, 2023
@sigstore sigstore deleted a comment Dec 15, 2023
@sigstore sigstore deleted a comment Dec 15, 2023
@sigstore sigstore deleted a comment Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants