add script to run hash algorithm benchmark #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
force-pushed
the
benchmark
branch
from
a94a8ed to
1ed45f0
Compare
As far as hashing is concerned, bytes are bytes. By generating our own bytes, we avoid I/O associated with reading models from disk. While we could read the model into memory, recreating the filesystem seems complicated. Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
force-pushed
the
benchmark
branch
from
840f809 to
6395b78
Compare
spencerschrock
commented
Jan 14, 2025
benchmarks/exp_hash.py
Outdated
| hasher = _get_hasher(algorithm) | ||
|
|
||
| def hash(hasher=hasher, size=size): | ||
| hasher.update(data[:size]) |
There was a problem hiding this comment.
Should we reinitialize the hasher too under the measured scope? We can make _get_hasher return just the constructor and call it here
There was a problem hiding this comment.
since this is in the inner most loop, it's always a new hasher. I dont think we need to reset anything
There was a problem hiding this comment.
But each call of hash from timeit just hashes data, it doesn't time the time it takes to init the hasher.
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
mihaimaruseac
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Builds upon the work in #306 and starts to define individual experiments. This one is aimed specifically at hashing algorithm.
As far as hashing is concerned, bytes are bytes. By generating our own bytes, we avoid I/O associated with reading models from disk. While we could read actual models into memory, recreating the filesystem seems unecessary for this benchmark.
Release Note
NONE
Documentation
NONE