Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose webhook affinity via values.yaml #871

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shearn89
Copy link

@shearn89 shearn89 commented Dec 12, 2024

Description of the change

Expose affinity via values.yaml for the Webhook

Existing or Associated Issue(s)

Supports #814

Additional Information

I have the policy controller webhook deployed to my cluster, and have noticed that both replicas are on the same node. This is due to the preferredDuring... setting in the default affinity. I would also like to prefer different AZs, and require different nodes. To do this the user must be able to configure the affinity settings manually.

image

Checklist

  • Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@shearn89
Copy link
Author

Tested locally with helm template - correctly reads the default if values.yaml/affinity is {}, and overrides otherwise.

@shearn89
Copy link
Author

shearn89 commented Dec 12, 2024

Also if instructions could be added to the CONTRIBUTING.md that explain how to generate the schema, that would be ideal.

NVM, remembered.

@shearn89 shearn89 force-pushed the feature/support-affinity-settings-in-values branch from 89bcdbe to a70a56d Compare December 12, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant