Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fulcio/add-env): Add additional env variables #530

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(helm): make env variable optional
Signed-off-by: saisatish karra <saisatish.karra@konghq.com>
  • Loading branch information
saisatishkarra committed May 19, 2023
commit bef4aba9bf4b46b15991d39c79c3d51208186a54
2 changes: 0 additions & 2 deletions charts/fulcio/values.schema.json
Original file line number Diff line number Diff line change
@@ -82,7 +82,6 @@
"grpcSvcPort",
"image",
"args",
"env",
"serviceAccount",
"service",
"ingress",
@@ -285,7 +284,6 @@
"type": "object",
"default": {},
"title": "The env Schema",
"required": [],
"properties": {},
"examples": [
{
6 changes: 3 additions & 3 deletions charts/fulcio/values.yaml
Original file line number Diff line number Diff line change
@@ -20,9 +20,9 @@ server:
# crane digest gcr.io/projectsigstore/fulcio:v1.3.1
# -- v1.3.1
version: sha256:c920be2d367214562cda7d53d3af3529edf2dfd9326b24909ece450092b97b18
env:
# Valid values: path to workload identity config or service account key JSON file
GOOGLE_APPLICATION_CREDENTIALS: /etc/fulcio-config/cloud_credentials
# env:
# # Valid values: path to workload identity config or service account key JSON file
# GOOGLE_APPLICATION_CREDENTIALS: /etc/fulcio-config/cloud_credentials
args:
port: 5555
grpcPort: 5554
Loading