Resolve or feedback for env section

Signed-off-by: Wayne Starr <[email protected]>
sigstore · Aug 4, 2024 · 3b3044d · 3b3044d
1 parent 255a247
commit 3b3044d
Showing 1 changed file with 6 additions and 13 deletions.
diff --git a/charts/fulcio/templates/fulcio-deployment.yaml b/charts/fulcio/templates/fulcio-deployment.yaml
@@ -71,27 +71,20 @@ spec:
             {{- range .Values.server.extraArgs }}
             - {{ . | quote }}
             {{- end }}
-{{- if .Values.server.env }}
+        {{- if or .Values.server.env (eq .Values.server.args.certificateAuthority "fileca") }}
           env:
-{{- range $key, $value := .Values.server.env }}
+          {{- range $key, $value := .Values.server.env }}
           - name: "{{ $key }}"
             value: "{{ $value }}"
-{{- end }}
-{{- if eq .Values.server.args.certificateAuthority "fileca" }}
+          {{- end }}
+          {{- if eq .Values.server.args.certificateAuthority "fileca" }}
           - name: PASSWORD
             valueFrom:
               secretKeyRef:
                 name: {{ .Values.server.secret }}
                 key: password
-{{- end }}
-{{- else if eq .Values.server.args.certificateAuthority "fileca" }}
-          env:
-          - name: PASSWORD
-            valueFrom:
-              secretKeyRef:
-                name: {{ .Values.server.secret }}
-                key: password
-{{- end }}
+          {{- end }}
+        {{- end }}
           livenessProbe:
             failureThreshold: 3
             httpGet: