Skip to content

Commit

Permalink
fix(helm): make env variable optional
Browse files Browse the repository at this point in the history
Signed-off-by: saisatish karra <[email protected]>
  • Loading branch information
saisatishkarra committed May 19, 2023
1 parent af3fc29 commit 066dec4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 0 additions & 2 deletions charts/fulcio/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@
"grpcSvcPort",
"image",
"args",
"env",
"serviceAccount",
"service",
"ingress",
Expand Down Expand Up @@ -285,7 +284,6 @@
"type": "object",
"default": {},
"title": "The env Schema",
"required": [],
"properties": {},
"examples": [
{
Expand Down
6 changes: 3 additions & 3 deletions charts/fulcio/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ server:
# crane digest gcr.io/projectsigstore/fulcio:v1.3.1
# -- v1.3.1
version: sha256:c920be2d367214562cda7d53d3af3529edf2dfd9326b24909ece450092b97b18
env:
# Valid values: path to workload identity config or service account key JSON file
GOOGLE_APPLICATION_CREDENTIALS: /etc/fulcio-config/cloud_credentials
# env:
# # Valid values: path to workload identity config or service account key JSON file
# GOOGLE_APPLICATION_CREDENTIALS: /etc/fulcio-config/cloud_credentials
args:
port: 5555
grpcPort: 5554
Expand Down

0 comments on commit 066dec4

Please sign in to comment.