README: add warning about internet access #596
Conversation
|
thanks @philips can you please sign the DCO |
gitsign differs from GPG in that it requires an internet access on every commit. This breaks the git model of working offline. So, probably worth calling out. Signed-off-by: Brandon Philips <[email protected]>
|
@cpanato signed DCO |
|
|
||
|
|
||
| # Warning: Setting this will make git commit/tag reliant on internet. | ||
| # Alternatively, don't use these settings and add the -S flag instead. |
There was a problem hiding this comment.
The -S flag for commits will still rely on the internet, no? I wonder if this message belongs elsewhere more prominently for gitsign use as a whole?
There was a problem hiding this comment.
Yeah, explaining that every signed commit now reaches out to the internet might be worth mentioning somewhere. I had setup this setting and then couldn't figure out why commits were happening so slowly.
There was a problem hiding this comment.
perhaps adding some text in the signing commits and signing tags sections makes sense? https://github.com/sigstore/gitsign/blob/main/README.md?plain=1#L115
There was a problem hiding this comment.
will be good to add some clarification in this section as well
Summary
gitsign differs from GPG in that it requires an internet access on every commit. This breaks the git model of working offline. So, probably worth calling out.
Release Note
NONE
Documentation