Bump Go to 1.23.2 and golangci-lint to 1.61 (#576)

* Bump Go to 1.23.2 and golangci-lint to 1.61 Signed-off-by: Aditya Sirish A Yelgundhalli <[email protected]> * Make linter happy Signed-off-by: Aditya Sirish A Yelgundhalli <[email protected]> --------- Signed-off-by: Aditya Sirish A Yelgundhalli <[email protected]>
sigstore · Oct 18, 2024 · 3a6b5ff · 3a6b5ff
1 parent ec41a4e
commit 3a6b5ff
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 12 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -17,7 +17,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
-          go-version: "1.22"
+          go-version: "1.23"
           check-latest: true
 
       - name: Build

diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml
@@ -32,7 +32,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
-          go-version: "1.22"
+          go-version: "1.23"
           check-latest: true
 
       - name: Get test OIDC token

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -21,7 +21,7 @@ jobs:
 
       - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
-          go-version: '1.22'
+          go-version: '1.23'
           check-latest: true
 
       - uses: imjasonh/setup-crane@31b88efe9de28ae0ffa220711af4b60be9435f6e # v0.4

diff --git a/.github/workflows/validate-release.yml b/.github/workflows/validate-release.yml
@@ -15,7 +15,7 @@ jobs:
 
       - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
-          go-version: '1.22'
+          go-version: '1.23'
           check-latest: true
 
       - uses: actions/cache@3624ceb22c1c5a301c8db4169662070a689d9ea8 # v4.1.1

diff --git a/.github/workflows/verify.yml b/.github/workflows/verify.yml
@@ -15,7 +15,7 @@ jobs:
       - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
       - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
-          go-version: '1.22'
+          go-version: '1.23'
           check-latest: true
       - name: Install addlicense
         run: go install github.com/google/[email protected]
@@ -36,12 +36,12 @@ jobs:
       - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
       - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
-          go-version: '1.22'
+          go-version: '1.23'
           check-latest: true
       - name: golangci-lint
         uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8 # v6.1.1
         with:
-          version: v1.59
+          version: v1.61
           args: --timeout 10m
 
   generate-docs:
@@ -51,7 +51,7 @@ jobs:
       - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
       - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
-          go-version: '1.22'
+          go-version: '1.23'
           check-latest: true
       - name: Check CLI docs are up to date
         run: ./hack/presubmit.sh
diff --git a/.golangci.yml b/.golangci.yml
@@ -28,10 +28,10 @@ issues:
   - text: "SA1019: package golang.org/x/crypto/openpgp"
     linters:
     - staticcheck
+  exclude-dirs:
+    - internal/fork
   max-issues-per-linter: 0
   max-same-issues: 0
 run:
   issues-exit-code: 1
   timeout: 10m
-  skip-dirs:
-    - internal/fork
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/sigstore/gitsign
 
-go 1.22.5
+go 1.23.2
 
 require (
 	github.com/coreos/go-oidc/v3 v3.11.0

diff --git a/internal/rekor/oid/oid_test.go b/internal/rekor/oid/oid_test.go
@@ -51,7 +51,7 @@ func TestOID(t *testing.T) {
 	}
 
 	if diff := cmp.Diff(tlog, got); diff != "" {
-		t.Errorf(diff)
+		t.Error(diff)
 	}
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -51,7 +51,7 @@ func TestOID(t *testing.T) { @@
     	}
     	if diff := cmp.Diff(tlog, got); diff != "" {
-    		t.Errorf(diff)
+    		t.Error(diff)
     	}
     }
@@ Expand Down @@