-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable CGO on release builds #1368
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1368 +/- ##
==========================================
- Coverage 57.66% 57.56% -0.10%
==========================================
Files 50 50
Lines 3111 3111
==========================================
- Hits 1794 1791 -3
- Misses 1159 1161 +2
- Partials 158 159 +1 |
cc: @jku |
I don't know any reason we need root. @bobcallaway @cpanato Are you aware of any reason? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, i can't think of a reason we need CGO or root
4567b99
to
a919dc9
Compare
Can you also change it in Line 5 in dd9a105
|
Update to debian12-static, we do not need libssl or libc from base Disable cgo in Makefile and goreleaser Signed-off-by: Appu Goundan <[email protected]>
a919dc9
to
7cd48d0
Compare
It looks like Dockerfile has CGO_ENABLED=1, but that looks like a local development build?? |
Correct, that should only be used for local testing and docker compose. |
@cpanato what's the testing strategy for this change? should I swap to the |
I've switched to |
sorry, i am a bit busy with company work this looks good to me as well |
Update to base-debian12
Open questions?
base-nossl...
instead?non-root
mode?