Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UseSignedTimestamps to CheckOpts, refactor TSA options #4006

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codysoyland
Copy link
Member

Summary

This PR adds UseSignedTimestamps to CheckOpts and refactors TSA options to improve readability, consistency, and error handling.

This is partially split out of #3889, where we will need CheckOpts.UseSignedTimestamps in order to set the options needed by sigstore-go's verifier.

Release Note

Documentation

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 27 lines in your changes missing coverage. Please review.

Project coverage is 36.51%. Comparing base (2ef6022) to head (9d3753b).
Report is 275 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cosign/verify.go 11.11% 7 Missing and 1 partial ⚠️
cmd/cosign/cli/verify/verify_blob_attestation.go 14.28% 3 Missing and 3 partials ⚠️
cmd/cosign/cli/verify/verify_blob.go 44.44% 3 Missing and 2 partials ⚠️
cmd/cosign/cli/verify/verify.go 0.00% 3 Missing ⚠️
cmd/cosign/cli/verify/verify_attestation.go 0.00% 3 Missing ⚠️
cmd/cosign/cli/verify.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4006      +/-   ##
==========================================
- Coverage   40.10%   36.51%   -3.59%     
==========================================
  Files         155      209      +54     
  Lines       10044    13345    +3301     
==========================================
+ Hits         4028     4873     +845     
- Misses       5530     7851    +2321     
- Partials      486      621     +135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant