Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up #4004

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Clean up #4004

merged 2 commits into from
Jan 10, 2025

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jan 8, 2025

Summary

  • bump golanci-lint
  • drop toolchain

Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.51%. Comparing base (2ef6022) to head (e2a74ad).
Report is 275 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4004      +/-   ##
==========================================
- Coverage   40.10%   36.51%   -3.59%     
==========================================
  Files         155      209      +54     
  Lines       10044    13359    +3315     
==========================================
+ Hits         4028     4878     +850     
- Misses       5530     7860    +2330     
- Partials      486      621     +135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go 1.23.2

toolchain go1.23.4
go 1.23.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop this down to 1.23.0 and do the same thing we did in sigstore/sigstore to test against the latest Go?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried but when running go mod tidy it update to 1.23.4 i think some dependencies are set to 1.23.4

@cpanato cpanato merged commit 87c08b0 into sigstore:main Jan 10, 2025
23 checks passed
@cpanato cpanato deleted the clean branch January 10, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants