Add more complex TUF tests #4003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for invalid keys, custom metadata, and TSA verification. These tests do not test the signing flow for when Fulcio issues a detached SCT, which can be affected by the TUF client, because the ephemral CA Fulcio backend cannot issue detached SCTs. Signed-off-by: Colleen Murphy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4003 +/- ##
==========================================
- Coverage 40.10% 36.51% -3.59%
==========================================
Files 155 209 +54
Lines 10044 13359 +3315
==========================================
+ Hits 4028 4878 +850
- Misses 5530 7860 +2330
- Partials 486 621 +135 ☔ View full report in Codecov by Sentry. |
haydentherapper
approved these changes
Jan 8, 2025
jku
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
looks good to me, cases look reasonable.
cosign shouldn't really test tuf internals of course... but since the client does not yet use trusted_root.json and needs to do this meddling in the TUF internal, the test makes sense as well (and should translate to similar simpler tests in the future when we can just test the trusted_root.json parsing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for invalid keys, custom metadata, and TSA verification.
These tests do not test the signing flow for when Fulcio issues a detached SCT, which can be affected by the TUF client, because the ephemral CA Fulcio backend cannot issue detached SCTs.
Summary
Release Note
Documentation