Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fulcio-spec.md #3

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Create fulcio-spec.md #3

merged 3 commits into from
Aug 15, 2024

Conversation

tracymiranda
Copy link

Move Fulcio spec from Google doc to Github

Summary

This is the first Sigstore spec doc being moved to github for public collaboration

Release Note

NONE

Documentation

This migrates the Google doc with the following modifications:

  • Add title and summary
  • Separate introduction (why) and overview (what) sections
  • Add numbering to sections for ease of referencing sections
  • Improve consistency and conciseness of some text

Move spec from Google doc to Github

Signed-off-by: Tracy Miranda <[email protected]>
fulcio-spec.md Outdated Show resolved Hide resolved
fulcio-spec.md Outdated Show resolved Hide resolved
fulcio-spec.md Outdated Show resolved Hide resolved
fulcio-spec.md Outdated Show resolved Hide resolved
@pwelch
Copy link
Member

pwelch commented Jul 24, 2024

Thanks for migrating this!

fulcio-spec.md Outdated Show resolved Hide resolved
fulcio-spec.md Outdated Show resolved Hide resolved
Signed-off-by: Tracy Miranda <[email protected]>
This was referenced Jul 25, 2024
@tracymiranda
Copy link
Author

Based on initial reviews I've added the OIDC link and fixed the spacing issues.
For feedback on the terminology I've opened up issues so we can get reviews on it from the original authors.

Signed-off-by: Tracy Miranda <[email protected]>
@tracymiranda
Copy link
Author

Thanks for the review @haydentherapper, added in the fixes from @chinenyeokafor's review.

@tracymiranda tracymiranda requested a review from pwelch August 6, 2024 17:08
@bobcallaway bobcallaway merged commit 482786a into sigstore:main Aug 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants