Fixes for Issues #8 and #9 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimKam
requested changes
Oct 11, 2023
.gitignore
Outdated
|
|
||
| tutorial/conf.py | ||
| test.mmd |
There was a problem hiding this comment.
Nit-pick: I wouldn't ignore the test.mmd file, which seems to be kind of random...
| return self.sequence | ||
| except Exception: | ||
| logging.warning( | ||
| "\nCould not execute model. Make sure that model is:\n1. Formatted correctly.\n2. File ends with .xml or .json." | ||
| ) | ||
|
|
||
| def validate_edge_cases(self): |
There was a problem hiding this comment.
Can you add a comment/docstring here that describes the edge cases that you are fixing?
Perhaps, it makes sense to have a more specific function name, because an edge case could be just about anything...
Removed some unnecessary igonores
* Small changes based on review comments * Linting issue * lint * lint * lint --------- Co-authored-by: MarcusRostSAP <[email protected]>
TimKam
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix Issue #8 and #9.
The approach is quite naive and implements a for-loop with O(n) to fix the edge-cases mentioned in the Issues.
Let me know if a more in-depth solution is wanted!