Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete pod security policy, enable network explorer functional tests #953

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

omrozowicz-splunk
Copy link
Contributor

@omrozowicz-splunk omrozowicz-splunk commented Oct 9, 2023

Description:
Delete deprecated PodSecurityPolicy so Network Explorer can work again.

Issue: #896

Testing: Manual tests + enabling network explorer in functional tests

Documentation: No documentation needed.


I tested it on microk8s cluster, network explorer pods were initialised successfully and network metrics were gathered:
image

I don't see all the documented ones, but I don't have any errors so it might be they're not present on my env.

  • I wanted to use functional tests we have now to test if behaviour is the same as before deprecation, but looks like network metrics were never tested there (as the condition was events >= 0), I spent some time to try to make network explorer work on minikube to make it a part of testing CI, but that still not sure if it is achievable. Now I see it's going to be disabled completely: End to end tests in Golang #951, so no need for me to work any further on it.

@omrozowicz-splunk omrozowicz-splunk requested review from a team as code owners October 9, 2023 12:48
@jvoravong jvoravong merged commit 28068f4 into signalfx:main Oct 9, 2023
19 checks passed
@atoulme
Copy link
Contributor

atoulme commented Oct 10, 2023

Indeed. We will bring back network explorer tests in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants