Refactoring after #1481 - removing not needed env variables #1540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cleanup and refactor work to prevent code duplication related to setting Kubernetes attributes by using k8sAttributesProcessor for cluster receiver introduced by PR
Once following two PRs will be merged we can merge this one:
We need also decide what to do with
resource/add_collector_k8s
: linkas this is using env variables which we want to remove, but the functionality of adding additional parameters is covered by
k8sattributes/metrics
, so probably it is safe to removeresource/add_collector_k8s
from configuration