Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm hook to instrumentation.yaml to accommodate new way CRDs are installed #1511

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Add helm hook to instrumentation.yaml to accommodate new way CRDs are installed #1511

merged 1 commit into from
Oct 28, 2024

Conversation

jvoravong
Copy link
Contributor

  • This PR introduces installing our Instrumentation opentelemetry.io/v1alpha1 using a Helm hook in this chart when Operator auto-instrumentation is used.
  • Due to upstream Operator chart changes, CRDs are now installed as a template during the install phase and thus we are required to install our Instrumentation opentelemetry.io/v1alpha1 as part of the post-install and post-upgrade phases.
    • CRDs and instances of those CRDs cannot be installed in the same phase during Helm install and upgrade actions.

@jvoravong jvoravong requested review from a team as code owners October 28, 2024 14:38
@jvoravong jvoravong merged commit f43230e into main Oct 28, 2024
40 checks passed
@jvoravong jvoravong deleted the otl-3062 branch October 28, 2024 15:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atoulme atoulme atoulme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvoravong @atoulme