Added fsyncEnabled option to values.yaml

signalfx · Sep 3, 2024 · c1d9131 · c1d9131
1 parent ef41ee7
commit c1d9131
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 0 deletions.
diff --git a/.chloggen/addfsyncflagconfig.yaml b/.chloggen/addfsyncflagconfig.yaml
@@ -0,0 +1,8 @@
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: enhancement
+# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
+component: agent
+# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Added `fsyncFlag` configuration to allow users to enable fsync on the filestorage.
+# One or more tracking issues related to the change
+issues: [1425]
diff --git a/helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl b/helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
@@ -9,12 +9,18 @@ extensions:
   {{- if and (eq (include "splunk-otel-collector.logsEnabled" .) "true") (eq .Values.logsEngine "otel") }}
   file_storage:
     directory: {{ .Values.logsCollection.checkpointPath }}
+    {{- if not (eq (toString .Values.splunkPlatform.fsyncEnabled) "<nil>") }}
+    fsync: {{ .Values.splunkPlatform.fsyncEnabled }}
+    {{- end }}
   {{- end }}
 
   {{- if .Values.splunkPlatform.sendingQueue.persistentQueue.enabled }}
   file_storage/persistent_queue:
     directory: {{ .Values.splunkPlatform.sendingQueue.persistentQueue.storagePath }}/agent
     timeout: 0
+    {{- if not (eq (toString .Values.splunkPlatform.fsyncEnabled) "<nil>") }}
+    fsync: {{ .Values.splunkPlatform.fsyncEnabled }}
+    {{- end }}
   {{- end }}
 
 

diff --git a/helm-charts/splunk-otel-collector/values.schema.json b/helm-charts/splunk-otel-collector/values.schema.json
@@ -154,6 +154,9 @@
               }
             }
           }
+        },
+        "fsyncEnabled": {
+          "type": "boolean"
         }
       },
       "anyOf": [

diff --git a/helm-charts/splunk-otel-collector/values.yaml b/helm-charts/splunk-otel-collector/values.yaml
@@ -121,6 +121,11 @@ splunkPlatform:
       enabled: false
       storagePath: "/var/addon/splunk/exporter_queue"
 
+  # Option to set fsync value for filestorage extension used by the agent. Enabling this option will ensure
+  # database integrity at the cost of performance. If not set it will use default value for this extension.
+  # Refer to: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/storage/filestorage#file-storage
+  # fsyncEnabled: true
+
 ################################################################################
 # Splunk Observability configuration
 ################################################################################
-Original file line number
+Diff line change
@@ Expand Up / @@ -154,6 +154,9 @@ @@
                   }
                 }
               }
+            },
+            "fsyncEnabled": {
+              "type": "boolean"
             }
           },
           "anyOf": [
@@ Expand Down @@