This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
session_state
structs include apending_key_exchange
variable, which (in my humble opinion) is unused and can be removed. Here is my reasoning:session_state.c
inside functions for serialization and deserialization, and the data is never modified or read.libsignal-protocol-c
.pending_key_exchange
is accessible through several functions in thesession_state.h
header, this header is not included insignal-protocol.h
, which is the main way for any program to interact with the code.pending_key_exchange
, except for consistency checks ofsession_state
, where it is manually set.So correct me if I'm wrong, but it looks like
pending_key_echange
is legacy code that is no longer useful and can be removed.