search: exclude "Single"/"EP" text from album artist list #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
=======================================
Coverage 95.07% 95.08%
=======================================
Files 40 40
Lines 2357 2360 +3
=======================================
+ Hits 2241 2244 +3
Misses 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This is fine but the translations are incomplete. It's fairly easy to retrieve the correct values automatically by looping over the Please also add tests. |
sgvictorino
force-pushed
the
album-artists-exclude-release-type-text
branch
2 times, most recently
from
0732f0f to
7e9e95c
Compare
```diff
next(r for r in yt.search("Eminem Houdini", filter="albums") if r["title"] == "Houdini")["artists"]
[
- {'name': 'Single', 'id': None},
{'name': 'Eminem', 'id': 'UCedvOgsKFzcK3hA5taf3KoQ'}
]
```
sgvictorino
force-pushed
the
album-artists-exclude-release-type-text
branch
from
7e9e95c to
c3dd26a
Compare
sigma67
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next(r for r in yt.search("Eminem Houdini", filter="albums") if r["title"] == "Houdini")["artists"] [ - {'name': 'Single', 'id': None}, {'name': 'Eminem', 'id': 'UCedvOgsKFzcK3hA5taf3KoQ'} ]