fix: fix compatibility for other kinds (#541)

sighupio · Sep 26, 2024 · 09e6034 · 09e6034
1 parent 6cbd473
commit 09e6034
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 18 deletions.
diff --git a/internal/distribution/compatibility.go b/internal/distribution/compatibility.go
@@ -85,7 +85,7 @@ func (c *EKSClusterCheck) IsCompatible() bool {
 		return false
 	}
 
-	max12SevenVersion, err := semver.NewVersion("v1.27.8")
+	max12SevenVersion, err := semver.NewVersion("v1.27.9")
 	if err != nil {
 		return false
 	}
@@ -95,7 +95,7 @@ func (c *EKSClusterCheck) IsCompatible() bool {
 		return false
 	}
 
-	max12EightVersion, err := semver.NewVersion("v1.28.3")
+	max12EightVersion, err := semver.NewVersion("v1.28.4")
 	if err != nil {
 		return false
 	}
@@ -105,7 +105,7 @@ func (c *EKSClusterCheck) IsCompatible() bool {
 		return false
 	}
 
-	max12NineVersion, err := semver.NewVersion("v1.29.3")
+	max12NineVersion, err := semver.NewVersion("v1.29.4")
 	if err != nil {
 		return false
 	}
@@ -158,7 +158,7 @@ func (c *KFDDistributionCheck) IsCompatible() bool {
 		return false
 	}
 
-	max12SevenVersion, err := semver.NewVersion("v1.27.8")
+	max12SevenVersion, err := semver.NewVersion("v1.27.9")
 	if err != nil {
 		return false
 	}
@@ -168,7 +168,7 @@ func (c *KFDDistributionCheck) IsCompatible() bool {
 		return false
 	}
 
-	max12EightVersion, err := semver.NewVersion("v1.28.3")
+	max12EightVersion, err := semver.NewVersion("v1.28.4")
 	if err != nil {
 		return false
 	}
@@ -178,7 +178,7 @@ func (c *KFDDistributionCheck) IsCompatible() bool {
 		return false
 	}
 
-	max12NineVersion, err := semver.NewVersion("v1.29.3")
+	max12NineVersion, err := semver.NewVersion("v1.29.4")
 	if err != nil {
 		return false
 	}

diff --git a/internal/distribution/compatibility_test.go b/internal/distribution/compatibility_test.go
@@ -51,8 +51,8 @@ func TestEKSClusterCheckIsCompatible(t *testing.T) {
 			expected:            false,
 		},
 		{
-			name:                "should return false if distribution version is greater than 1.27.8",
-			distributionVersion: "v1.27.9",
+			name:                "should return false if distribution version is greater than 1.27.9",
+			distributionVersion: "v1.27.10",
 			expected:            false,
 		},
 		{
@@ -61,8 +61,8 @@ func TestEKSClusterCheckIsCompatible(t *testing.T) {
 			expected:            true,
 		},
 		{
-			name:                "should return false if distribution version is greater than 1.28.3",
-			distributionVersion: "v1.28.4",
+			name:                "should return false if distribution version is greater than 1.28.4",
+			distributionVersion: "v1.28.5",
 			expected:            false,
 		},
 		{
@@ -71,8 +71,8 @@ func TestEKSClusterCheckIsCompatible(t *testing.T) {
 			expected:            true,
 		},
 		{
-			name:                "should return false if distribution version is greater than 1.29.3",
-			distributionVersion: "v1.29.4",
+			name:                "should return false if distribution version is greater than 1.29.4",
+			distributionVersion: "v1.29.5",
 			expected:            false,
 		},
 	}
@@ -138,8 +138,8 @@ func TestKFDDistributionCheckIsCompatible(t *testing.T) {
 			expected:            true,
 		},
 		{
-			name:                "should return false if distribution version is greater than 1.27.8",
-			distributionVersion: "v1.27.9",
+			name:                "should return false if distribution version is greater than 1.27.9",
+			distributionVersion: "v1.27.10",
 			expected:            false,
 		},
 		{
@@ -148,8 +148,8 @@ func TestKFDDistributionCheckIsCompatible(t *testing.T) {
 			expected:            true,
 		},
 		{
-			name:                "should return false if distribution version is greater than 1.28.3",
-			distributionVersion: "v1.28.4",
+			name:                "should return false if distribution version is greater than 1.28.4",
+			distributionVersion: "v1.28.5",
 			expected:            false,
 		},
 		{
@@ -158,8 +158,8 @@ func TestKFDDistributionCheckIsCompatible(t *testing.T) {
 			expected:            true,
 		},
 		{
-			name:                "should return false if distribution version is greater than 1.29.3",
-			distributionVersion: "v1.29.4",
+			name:                "should return false if distribution version is greater than 1.29.4",
+			distributionVersion: "v1.29.5",
 			expected:            false,
 		},
 	}