Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python(chore): csv example ingestion #96

Merged
merged 12 commits into from
Sep 17, 2024
Merged

Conversation

niliayu
Copy link
Collaborator

@niliayu niliayu commented Sep 16, 2024

Adds an example of how to ingest data from a CSV file. This example is simple and makes a few assumptions (e.g. channels are all doubles), but hopefully is easy enough to understand an expand from for other uses.

@niliayu niliayu requested a review from solidiquis September 16, 2024 21:00
Copy link
Collaborator

@solidiquis solidiquis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes! There were some things I did in the original example that aren't suitable to show to users in official examples so we'll get those cleaned up :)

python/examples/ingestion_with_csv/main.py Outdated Show resolved Hide resolved
python/examples/ingestion_with_csv/main.py Outdated Show resolved Hide resolved
python/examples/ingestion_with_csv/main.py Outdated Show resolved Hide resolved
@niliayu niliayu requested a review from solidiquis September 16, 2024 21:56
Copy link
Collaborator

@solidiquis solidiquis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple tiny nits and one final request: Would you mind truncating the CSV to just have 50 rows? The CSV as is is quite large and it'll blow up our repo size. 50 rows will get the same point across :)

python/examples/ingestion_with_csv/main.py Outdated Show resolved Hide resolved
python/examples/ingestion_with_csv/main.py Outdated Show resolved Hide resolved
@niliayu niliayu force-pushed the ayu/csv-ingestion-example branch from 78a5220 to 3e18495 Compare September 17, 2024 00:14
@niliayu niliayu requested a review from solidiquis September 17, 2024 00:43
Copy link
Collaborator

@solidiquis solidiquis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for iterating with me!

@niliayu
Copy link
Collaborator Author

niliayu commented Sep 17, 2024

Thanks for the quick feedback, super helpful in learning the patterns here!

@niliayu niliayu merged commit a2084c1 into main Sep 17, 2024
7 checks passed
@niliayu niliayu deleted the ayu/csv-ingestion-example branch September 17, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants