Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python(feature): saved search, rule versions, file attachments protos #84

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

solidiquis
Copy link
Collaborator

Changes:

Python protobuf code-gen with recent updates to Sift protocol buffers. Notable changes:

  1. SavedSearchService to interact with the saved searches API to save frequent searches for the homepage/overview.
  2. Added support to the RuleVersionService for rule versioning
  3. RemoteFileService for file attachment upload/download

@solidiquis solidiquis marked this pull request as ready for review August 16, 2024 18:13
@solidiquis solidiquis force-pushed the python/feature-proto-update branch from 26eeb73 to 6cef375 Compare August 16, 2024 18:18
Copy link
Collaborator

@zachAtSiftStack zachAtSiftStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

@solidiquis solidiquis merged commit 7e29667 into main Aug 16, 2024
7 checks passed
@solidiquis solidiquis deleted the python/feature-proto-update branch August 16, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants