Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python(feat): Add offline installation archives for various platforms #150

Merged
merged 75 commits into from
Dec 11, 2024

Conversation

kevin-sift
Copy link
Contributor

@kevin-sift kevin-sift commented Dec 9, 2024

Context

Some users wish to install sift-stack-py without access to pypi.

Description

This PR adds a new workflow python_build.yaml that builds offline installation archives (wheels for each dependency) that target all supported python versions and various platforms (linux, mac, windows) and architectures (e.g. x86_64/arm64).

Users will be able to install sift-py-stack by running pip install sift-py-stack --no-index --find-links {path/to/offline-installation-archive}.

Verification

Ran python_release.yaml workflow which calls the new python_build.yaml on a dev tag and successfully created a release

https://github.com/sift-stack/sift/actions/runs/12273019715

image

Manually downloaded and inspected archives as well as installing locally on my mac.

marcsiftstack and others added 30 commits December 9, 2024 15:16
also add .venv to gitignore
- Updated the build dependencies to include optional extras for building.
- Modified the test command to validate both standard and optional dependencies.
- Expanded the wheel checking step to include installation tests for various combinations of extras.

This improves the robustness of the build process and ensures all features are tested.
- Renamed workflow from "Build Wheels" to "Offline Installation Archive" to better reflect its purpose.
- Updated job names and structure to enhance clarity and organization.
- Added support for multiple architectures and operating systems in the build matrix.
- Introduced steps for generating requirements, downloading dependencies, and creating a distribution archive.
- Enhanced verification process by extracting and checking distributions before testing installations.
- Improved installation testing to cover various combinations of optional dependencies.

These changes streamline the CI process and ensure comprehensive testing of the package across different environments.
…thon packages. Renamed job to "Build and verify", added verification step for wheel files using twine, and implemented comprehensive installation tests for various dependency combinations. Updated installation steps and removed obsolete verification job to streamline the workflow.
@kevin-sift kevin-sift changed the title Kevin/feature/add python build gha python(feat): Add offline installation archives for various platforms Dec 11, 2024
@kevin-sift kevin-sift marked this pull request as ready for review December 11, 2024 09:17
A separate pr should put it in its own extras group
python/pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@solidiquis solidiquis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin-sift kevin-sift merged commit 6f3296b into main Dec 11, 2024
7 checks passed
@kevin-sift kevin-sift deleted the kevin/feature/add-python-build-gha branch December 11, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants