Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust(build): rc.2 prep + new examples #127

Merged
merged 10 commits into from
Nov 12, 2024
Merged

rust(build): rc.2 prep + new examples #127

merged 10 commits into from
Nov 12, 2024

Conversation

solidiquis
Copy link
Collaborator

@solidiquis solidiquis commented Nov 12, 2024 •
edited
Loading

Changes

  • Better documentation for Rust
  • Updated top-level documentation
  • New examples for Rust
  • rc.2 prep

niliayu
niliayu reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@niliayu niliayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The smallest of nits for a few doc typos

README.md Outdated Show resolved Hide resolved
rust/examples/ingestion/config.rs Outdated Show resolved Hide resolved
@solidiquis solidiquis requested a review from niliayu November 12, 2024 22:09
niliayu
niliayu approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@niliayu niliayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@solidiquis solidiquis merged commit 35ef3c1 into main Nov 12, 2024
7 checks passed
@solidiquis solidiquis deleted the rust/build-examples-rc.2 branch November 12, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niliayu niliayu niliayu approved these changes

@marcsiftstack marcsiftstack Awaiting requested review from marcsiftstack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solidiquis @niliayu