Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python(feat): Add timestamp arg to VideoMetadata #110

Merged
merged 1 commit into from
Oct 31, 2024
Merged

python(feat): Add timestamp arg to VideoMetadata #110

merged 1 commit into from
Oct 31, 2024

Conversation

marcsiftstack
Copy link
Contributor

@marcsiftstack marcsiftstack commented Oct 28, 2024 •
edited
Loading

Tested locally with:

    remote_file = file_attachment_service.upload_attachment(
        path="/Users/mjulien/Downloads/Short3.mp4",
        entity=run,
        metadata=VideoMetadata(height=2160, width=3840, duration_seconds=28, timestamp=datetime(2024, 10, 19, 2, 22, 22, tzinfo=timezone.utc)),
        description="thrusters getting too hot" ,
    )

@marcsiftstack marcsiftstack force-pushed the feature/videometadata-timestamp branch 2 times, most recently from 3adc803 to 9517084 Compare October 30, 2024 18:04
@marcsiftstack marcsiftstack changed the title Add tiemstamp arg to VideoMetadata python(feat): Add timestamp arg to VideoMetadata Oct 30, 2024
@marcsiftstack marcsiftstack force-pushed the feature/videometadata-timestamp branch from 9517084 to c403dc7 Compare October 30, 2024 18:09
@marcsiftstack marcsiftstack marked this pull request as ready for review October 30, 2024 18:12
niliayu
niliayu reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@niliayu niliayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm, just one little question!

python/lib/sift_py/file_attachment/metadata.py Show resolved Hide resolved
@marcsiftstack marcsiftstack removed the request for review from solidiquis October 31, 2024 20:26
@marcsiftstack marcsiftstack merged commit 67f416d into main Oct 31, 2024
7 checks passed
@marcsiftstack marcsiftstack deleted the feature/videometadata-timestamp branch October 31, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niliayu niliayu niliayu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcsiftstack @niliayu