-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Asset agnostic rule configs #100
Conversation
python/examples/ingestion_with_yaml_config/telemetry_configs/nostromo_lv_426.yml
Show resolved
Hide resolved
1e9ab35
to
e20b58e
Compare
Just rebased the branch since it was getting a bit stale. |
c527ccd
to
e8a0947
Compare
@marcsiftstack : Edit: This has now been addressed! |
7762fb4
to
ef3721b
Compare
f8480d7
to
98631a5
Compare
This PR adds the ability to define rules in YAML separate from the main telemetry config, so that rules may be referenced and reused in the context of multiple assets.
A rule that's defined in a namespace can be referenced in the main telemetry config like so:
With the corresponding rule defined in a separate YAML like so:
Or if the user wants to instantiate rules in python directly, the
load_rule_namespaces
function has been added that will allow them to provide a path to the directory containing their rule YAMLs and load them into memory:You can see examples of this rules in dev in this run: https://dev.app.siftstack.com/share/3xBUAIQ