-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update go structs with updated format for docgen #8198
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would break machine config comments, JSON schema generation, etc.
it doesn't cover new machine config documents either
|
I think this need to be planned properly with exact ideas on what is going to be dropped, moved, removed, etc. Can we do it with more transitional changes and less breaking changes? How it's going to look in the end and so on. So far it won't pass the CI even. |
This is a draft so I don't expect it to pass just yet. I posted in our private Slack I would like to discuss this week. This is just here in the form it is now to help illustrate the changes so we can have a more meaningful discussion. |
eb16550
to
0b24336
Compare
Picking this back up finally. Not ready for review yet but I want to use CI for testing. I plan on basing other PRs off of this one and going through a series of PRs that we can get aligned and push through. |
a23d5cc
to
24b7ef6
Compare
Not ready for review. Using CI to test. |
39a6532
to
82b5b14
Compare
6d3f41b
to
0d279b8
Compare
Updates Go types for compatibility with an external implementation of docgen. Signed-off-by: Andrew Rynhard <[email protected]>
No description provided.