Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve bond and ip kernel params #7448

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jared-gs
Copy link

@jared-gs jared-gs commented Jul 7, 2023

Pull Request

What? (description)

The bond and ip kernel params are typically used to configure networking on the host and should be preserved when Talos is installed

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)

See make help for a description of the available targets.

jared-gs added 2 commits July 7, 2023 12:13
The bond and ip kernel params are typically used to configure networking on the host and should be preserved when Talos is installed.
@smira
Copy link
Member

smira commented Jul 7, 2023

we would like to discuss this further, as it was supposed that kernel args only configure networking on the first boot (before machine config is acquired).

also there's a way to perform a special configuraiton of network params via META partition. in either case, I would love to see your flow and usecase to understand it better

@zviratko
Copy link

This would actually break my flow if implemented badly - I use a provisioning VLAN/Subnet on first boot but then I switch to a completely different one and I don't expect Talos to use an interface I didn't provision.

Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants