docs: Explain updating k8s components. #5959
Open
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explained that editing cluster config may also require a k8s-upgrade and component restart step, with link to 'upgrading kubernetes' docs. Updated these docs to explain that version-number can be preserved. Signed-off-by: Matthew Richardson <[email protected]>
smira
reviewed
Jul 25, 2022
| @@ -48,6 +48,8 @@ The list of config changes allowed to be applied immediately in Talos {{< releas | |||
| * `.machine.kernel` | |||
| * `.machine.registries` (CRI containerd plugin will not pick up the registry authentication settings without a reboot) | |||
|
|
|||
| Changes to `.cluster` configuration for Kubernetes components will not take effect until the Kubernetes cluster is [upgraded]({{< relref "../../kubernetes-guides/upgrading-kubernetes" >}}) and the components are restarted - either manually or via a reboot. | |||
There was a problem hiding this comment.
I think we might need more careful wording here.
There are two types of components configured in .cluster section:
- control plane components running as static pods (API server, controller manager and scheduler) - changes to these components are applied immediately on the fly
- other settings which in fact update bootstrap manifests - manifests themselves, CNI, kube-proxy configuration - these are not applied automatically, only missing resources are created, but existing ones are not updated (and never removed) - these require a Kubernetes upgrade to be applied
|
This PR is stale because it has been open 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What?
Explain that editing cluster config may also require a k8s-upgrade and component restart step,
with link to 'upgrading kubernetes' docs.
Updated these docs to explain that version-number can be preserved.
Signed-off-by: Matthew Richardson [email protected]
Why? (reasoning)
It is not currently clear that editing the
clusterpart of the machine config also requires these extra steps before the components will be running with the new config.Acceptance
make docs)