-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create kubelet certificates on controlplane #4325
base: main
Are you sure you want to change the base?
Conversation
Contolplane has root certificate and Talos can create kubelet client/server certificat at boot time. Signed-off-by: Serge Logvinov <[email protected]>
} | ||
|
||
kubeletClientKeyPair, err := x509.NewKeyPair(ca, | ||
x509.CommonName(constants.KubernetesKubeletCommonNamePrefix+nodename), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
evaluating certificates using Common Names is common... but discouraged. And some go libraries will actually migrate away from doing that. I suggest you instead rely on setting a SubjectAltName instead to avoid future problems.
Is there a proposal for this feature that describes the overall flow better? I'd like to know the plan for cert rotation which tends to be an issue |
Right now Talos doesn't manage kubelet certificates, and kubelet rotates the certificates on its own. We plan on taking over kubelet certificate management as part of bigger change to improve the node join security. |
that sounds like a good idea! I'd be happy to review if it helps. |
This PR is stale because it has been open 45 days with no activity. |
This PR solves two problems:
Result
Second
kubelet-server-2021-10-04-20-26-35.pem
file was rotated by kubelet.Acceptance
Please use the following checklist:
make conformance
)make fmt
)make lint
)make docs
)make unit-tests
)This change is