Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Cilium Installation Guide to include Gateway API #10091

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ganawaj
Copy link
Contributor

@ganawaj ganawaj commented Jan 6, 2025

Pull Request

What? (description)

Updates the Cilium Installation Guide to include links to the latest stable version (previous was 1.13, it is now 1.16).

Also includes a note about including ALPN & App Protocol to handle GRPC Connection

Why? (reasoning)

I was installing Omni on a Talos Cluster and running into issues using GatewayAPI as the ingress. I ran into an issue accessing Omni due to GRPC being downgraded HTTP/1.1 becuase ALPN could not be negotiated. After some troubleshooting, discovered ALPN needs to be

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)

See make help for a description of the available targets.

@ganawaj ganawaj changed the title Update Cilium Installation Guide to include Gateway API docs: pdate Cilium Installation Guide to include Gateway API Jan 6, 2025
@ganawaj ganawaj changed the title docs: pdate Cilium Installation Guide to include Gateway API docs: Update Cilium Installation Guide to include Gateway API Jan 6, 2025
Update version references, add Gateway API.

Signed-off-by: Andrey Smirnov <[email protected]>
Signed-off-by: Ganawa Juanah <[email protected]>
@smira smira force-pushed the update-docs-for-cilium branch from 59e6385 to cc84caf Compare January 8, 2025 12:05
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@smira
Copy link
Member

smira commented Jan 8, 2025

/m

@talos-bot talos-bot merged commit cc84caf into siderolabs:main Jan 8, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants