-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report guest uptime to the host #22
Conversation
this PR might need |
OK, a simple |
squash the commits anyways |
60df755
to
571c1a0
Compare
a0e8c29
to
20cce3d
Compare
It appears that the host needs to know the guest's uptime information to determine if a soft reboot was successful. Additionally, the uptime needs to be reported in response to the capabilities request. This commit includes the results of `make rekres`. Signed-off-by: Robin Elfrink <[email protected]>
Well, I thought I got to the bottom of the reboot-only-once-problem with the change status, but I was wrong. However while trying to find the flaws in my thinking, I stumbled upon some code from the original open-vm-tools, and a couple of interesting differences between logs of a talos-vmtoolsd and a debian guest. So it turns out that the host needs the guest's uptime information to know that a soft reboot has happened, and that information must be sent at a very specific place in the communication: the capabilities request. host: "what are your capabilities?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
It appears that the host needs to know the guest's uptime information to determine if a soft reboot was succesful.
Closes #21