feat: create 'ecr-credential-provider' extension #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preisschild
force-pushed
the
main
branch
5 times, most recently
from
76404a0 to
80245b1
Compare
Preisschild
force-pushed
the
main
branch
4 times, most recently
from
bf0564d to
7e1d2b2
Compare
|
@Preisschild sorry for holding on to this for long, i want to get some kubelet support worked on for extra config files in talos and then get back to this. I can rebase once that's done. |
frezbo
approved these changes
Nov 13, 2023
|
/ok-to-test |
Issue: siderolabs#241 Signed-off-by: Ströger Florian <[email protected]> Signed-off-by: Noel Georgi <[email protected]>
smira
approved these changes
Nov 13, 2023
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #241
This extension provides the ecr-credential-provider binary,
which can be executed by Kubelet to provide a short-lived token for pulling container images
from Amazon Web Services' Elastic Container Registry (ECR).