feat: implement bldr update --dry command
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
Unix4ever
approved these changes
Jul 12, 2021
|
would be nice to see output example in the comment ;) |
|
Updated description |
|
/approve |
| ) | ||
|
|
||
| func gitHubTokenFromEnv() string { | ||
| token := os.Getenv("BLDR_GITHUB_TOKEN") |
There was a problem hiding this comment.
It is just for convenience. BLDR_GITHUB_TOKEN is the bldr-specific token. If it is empty, we try GITHUB_TOKEN, which a common name for many tools that use GitHub API. We don't need any scope for it, so any working token will do.
| } | ||
|
|
||
| concurrency := runtime.GOMAXPROCS(-1) | ||
| var wg sync.WaitGroup |
There was a problem hiding this comment.
Should we use an error group? Do we want to treat a failed update is an error?
There was a problem hiding this comment.
At the moment, all errors are treated as warnings and logged and ignored below. Once more cases are covered, and the distinction between hard errors and warnings is more clear, this code will be updated to use ErrGroup.
Only for GitHub tags and releases for now. Refs siderolabs#48. Signed-off-by: Alexey Palazhchenko <[email protected]>
andrewrynhard
approved these changes
Jul 13, 2021
smira
approved these changes
Jul 13, 2021
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only for GitHub tags and releases for now.
Refs #48.