Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support --cache-from/--cache-imports #151

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

smira
Copy link
Member

@smira smira commented Sep 15, 2023

Inspiration taken from the dockerfile frontend.

Inspiration taken from the dockerfile frontend.

Signed-off-by: Andrey Smirnov <[email protected]>
var cacheImports []client.CacheOptionsEntry

// new API
if cacheImportsStr := opts[keyCacheImports]; cacheImportsStr != "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could actually pass in json and drop old api support at all if needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if buildx supports new API fully, this "new" API is 5 years old now

@smira
Copy link
Member Author

smira commented Sep 15, 2023

/m

@talos-bot talos-bot merged commit 20de986 into siderolabs:main Sep 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants