Decouple HTML to PDF logic from saving functionality for improved flexibility #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion, so that it is possible to retrieve the converted pdf result for further manipulation instead of saving directly
zoey-kaiser
approved these changes
Dec 7, 2023
4 tasks
|
Hi @tpkee 👋 Thanks for your contribution. I just made a new release with our changes. You can pull them in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometime I need to customise the pdf instance further instead of saving it directly, or outright open it in a new tab as a preview.
This PR decouples the HTML to PDF conversion logic from the saving function to enable retrieving the converted PDF result for additional manipulation, rather than direct saving.
Closes # .
Checklist:
#)