Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh(#843): Allow signup flow return data when preventLoginFlow is true #903
base: main
Are you sure you want to change the base?
Enh(#843): Allow signup flow return data when preventLoginFlow is true #903
Changes from 12 commits
e0136bd
7a4ed34
e3bf0fc
1bdf144
d9951f6
5477cde
0caeefc
a76b601
9cff966
e5373a4
6ee85a0
b25597b
86fd25a
94cd4a3
f11f9c4
98e33a9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update your handler to be closer to a demo implementation introduced in #901?
https://github.com/sidebase/nuxt-auth/blob/main/playground-local/server/api/auth/login.post.ts
I think you either can:
preventLoginFlow
, right?) innuxt-auth/playground-local/server/api/auth/login.post.ts
Lines 61 to 65 in 5276a97
signIn
handler so that reference is usable by others as inspiration and also by tests.nuxt-auth/playground-local/server/api/auth/login.post.ts
Lines 67 to 90 in 5276a97
It is fine for me if you don't want to implement option 2, I can take it over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should take over to implement option 2.
I'm not so confident in working with tokens, i would like to learn by seeing your implementation.
I don't mind trying to implement it though if you don't mind, although it might take some trial and error on on my part.