-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#836)!: unification and flexibility with AUTH_ORIGIN
#837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hywax π
Thanks for the PR! I hope to get around to a full review this week. I already noticed one small issue I commented below!
Co-authored-by: Marsel Shayhin <[email protected]>
Co-authored-by: Marsel Shayhin <[email protected]>
@zoey-kaiser break-change tag can be removed as backward compatibility is preserved |
Co-authored-by: Zoey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not need to be done in this PR. but as a follow-up let's:
- Adapt the
~/playground-*
to useNUXT_AUTH_ORIGIN
- Adapt any starter to use
NUXT_AUTH_ORIGIN
- Adapt the nuxt-auth-example to use
NUXT_AUTH_ORIGIN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a follow-up issue. The PR can be merged in its current state
π Linked issue
#836
β Type of change
π Description
Fully realized the whole idea of the issue.
π Checklist