Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#836)!: unification and flexibility with AUTH_ORIGIN #837

Merged
merged 15 commits into from
Aug 8, 2024

Conversation

hywax
Copy link
Contributor

@hywax hywax commented Jul 29, 2024

πŸ”— Linked issue

#836

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Fully realized the whole idea of the issue.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link
Member

@zoey-kaiser zoey-kaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hywax πŸ‘‹

Thanks for the PR! I hope to get around to a full review this week. I already noticed one small issue I commented below!

pnpm-lock.yaml Outdated Show resolved Hide resolved
@zoey-kaiser zoey-kaiser added enhancement An improvement that needs to be added breaking-change A change will changes that require at least a minor release. labels Jul 30, 2024
@hywax hywax requested a review from zoey-kaiser July 30, 2024 14:31
src/runtime/server/services/utils.ts Outdated Show resolved Hide resolved
src/runtime/types.ts Outdated Show resolved Hide resolved
@hywax hywax requested a review from phoenix-ru August 1, 2024 10:08
src/runtime/server/services/utils.ts Outdated Show resolved Hide resolved
docs/guide/application-side/configuration.md Outdated Show resolved Hide resolved
@hywax hywax requested a review from phoenix-ru August 4, 2024 09:20
@hywax
Copy link
Contributor Author

hywax commented Aug 5, 2024

@zoey-kaiser break-change tag can be removed as backward compatibility is preserved

phoenix-ru
phoenix-ru previously approved these changes Aug 8, 2024
@phoenix-ru
Copy link
Collaborator

@hywax thank you for taking your time to push this PR to the end, it's very appreciated.
I think in general it is in the right direction and I feel confident enough with merging it and picking up on your work to bring some improvements to origin detection discovered in #818

@phoenix-ru phoenix-ru removed the breaking-change A change will changes that require at least a minor release. label Aug 8, 2024
docs/guide/advanced/deployment/self-hosted.md Show resolved Hide resolved
docs/resources/error-reference.md Outdated Show resolved Hide resolved
Copy link
Member

@zoey-kaiser zoey-kaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not need to be done in this PR. but as a follow-up let's:

  • Adapt the ~/playground-* to use NUXT_AUTH_ORIGIN
  • Adapt any starter to use NUXT_AUTH_ORIGIN
  • Adapt the nuxt-auth-example to use NUXT_AUTH_ORIGIN

@phoenix-ru phoenix-ru mentioned this pull request Aug 8, 2024
2 tasks
Copy link
Collaborator

@phoenix-ru phoenix-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a follow-up issue. The PR can be merged in its current state

@phoenix-ru phoenix-ru merged commit 4729b1f into sidebase:main Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement that needs to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants