Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added token prefix option #652

Closed
wants to merge 3 commits into from

Conversation

FAL-coffee
Copy link
Contributor

@FAL-coffee FAL-coffee commented Feb 1, 2024

We will make it possible to change the prefix of the token stored in the Cookie upon refresh when using the local type or refresh type.

The reason this is necessary: When multiple environments are launched on localhost, conflicts occur in the token storage locations.

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • manually checked my feature / checking not applicable
  • wrote tests / testing not applicable
  • attached screenshots / screenshot not applicable

@carbontwelve
Copy link

carbontwelve commented Feb 1, 2024

May I suggest a slight modification, rather than defining the prefix, make both the token cookie and refresh cookie names configurable. Doing so would then solve for #650 due to : not being a valid character in a cookie name.

@FAL-coffee
Copy link
Contributor Author

@carbontwelve

that's a perspective I hadn't considered. Thank you for sharing it!
I'll make the revisions and commit them soon.

@FAL-coffee
Copy link
Contributor Author

I have created the following pull request: #654. I will close this PR now.

@FAL-coffee FAL-coffee closed this Feb 2, 2024
@FAL-coffee FAL-coffee deleted the option-to-token-prefix branch February 4, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants