-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement refresh provider schema #581
Conversation
fix bugs on reference of runtime config add headers on refresh methode Refs: sidebase#373
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I saw after a quick flyover is that there were no changes to the documentation. This would be needed before a release.
Do you feel like you could write these? Otherwise you can also ignore it for now and ill write some docs, while doing a functional review!
Is there an ETA as to when the new documentation will be released? |
I prefer ignore from now 😂😂 Still waiting for a beta release another name this week as expected |
Published alpha version can be found here https://www.npmjs.com/package/@dommidev10/nuxt-auth, thanks to @dommi10 ❤️ |
Hi @dommi10, could you please fix the lint issues? Then I will go ahead and review this! |
Sure, I will do it tomorrow |
hi @zoey-kaiser, i finished with lint fix |
Hi @dommi10 👋 I finally got around to the review! It already looks pretty good. I would suggest the following:
Ill text you in here once the beta release is done! |
Thanks you @zoey-kaiser |
Alpha version released! Thank you again for adding this ❤️ |
Thank you @zoey-kaiser for your dedicated time and suggestions |
this pull request is based on #373 with all bugs fixed and suggestion
Closes # .
Checklist:
#
)