Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement refresh provider schema #581

Merged
merged 17 commits into from
Nov 30, 2023
Merged

Conversation

dommi10
Copy link
Contributor

@dommi10 dommi10 commented Nov 21, 2023

this pull request is based on #373 with all bugs fixed and suggestion

Closes # .

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • manually checked my feature / checking not applicable
  • wrote tests / testing not applicable
  • attached screenshots / screenshot not applicable

fix bugs on reference of runtime config
add headers on refresh methode

Refs: sidebase#373
Copy link
Member

@zoey-kaiser zoey-kaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I saw after a quick flyover is that there were no changes to the documentation. This would be needed before a release.

Do you feel like you could write these? Otherwise you can also ignore it for now and ill write some docs, while doing a functional review!

@clcoco
Copy link

clcoco commented Nov 21, 2023

Is there an ETA as to when the new documentation will be released?

@dommi10
Copy link
Contributor Author

dommi10 commented Nov 21, 2023

What I saw after a quick flyover is that there were no changes to the documentation. This would be needed before a release.

Do you feel like you could write these? Otherwise you can also ignore it for now and ill write some docs, while doing a functional review!

I prefer ignore from now 😂😂
If things work as expected then we can think how to do that

Still waiting for a beta release another name this week as expected
@zoey

@zoey-kaiser
Copy link
Member

Published alpha version can be found here https://www.npmjs.com/package/@dommidev10/nuxt-auth, thanks to @dommi10 ❤️

@zoey-kaiser
Copy link
Member

Hi @dommi10, could you please fix the lint issues? Then I will go ahead and review this!

@dommi10
Copy link
Contributor Author

dommi10 commented Nov 23, 2023

Hi @dommi10, could you please fix the lint issues? Then I will go ahead and review this!

Sure, I will do it tomorrow

@dommi10
Copy link
Contributor Author

dommi10 commented Nov 24, 2023

Hi @dommi10, could you please fix the lint issues? Then I will go ahead and review this!

hi @zoey-kaiser, i finished with lint fix

@zoey-kaiser
Copy link
Member

Hi @dommi10 👋

I finally got around to the review! It already looks pretty good. I would suggest the following:

  • I merge this
  • Do a beta release with this new feature
  • We test this more inside the beta version
  • I make any changes I see that need to be made

Ill text you in here once the beta release is done!

@zoey-kaiser zoey-kaiser merged commit 81627c4 into sidebase:main Nov 30, 2023
4 checks passed
@zoey-kaiser zoey-kaiser mentioned this pull request Nov 30, 2023
3 tasks
@dommi10
Copy link
Contributor Author

dommi10 commented Nov 30, 2023

Thanks you @zoey-kaiser
I can't wait😇

@zoey-kaiser
Copy link
Member

zoey-kaiser commented Nov 30, 2023

Alpha version released! Thank you again for adding this ❤️

@dommi10
Copy link
Contributor Author

dommi10 commented Nov 30, 2023

Thank you @zoey-kaiser for your dedicated time and suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants