Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added option to set callbackUrl as external #556

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

zoey-kaiser
Copy link
Member

@zoey-kaiser zoey-kaiser commented Oct 23, 2023

Closes #553

You can now direct to an external url in the signin, signout and session methods:

signIn({ username, password }, { callbackUrl: 'https://sidebase.io', external: true })

Note: If this is set to true, then a hard page refresh will be done, therefore only set external to true, if you are really redirecting to a page outside of your application.

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • manually checked my feature / checking not applicable
  • wrote tests / testing not applicable
  • attached screenshots / screenshot not applicable

@zoey-kaiser
Copy link
Member Author

CC @IsraelOrtuno and @Jeroen-Cox as this is a follow up and change of how I implemented your solution in #429

@zoey-kaiser zoey-kaiser changed the title feat: Addd option to define callbackUrl as external feat: Addd option to set callbackUrl as external Oct 23, 2023
@IsraelOrtuno
Copy link
Contributor

I think this is good for now! 🎉

@zoey-kaiser zoey-kaiser changed the title feat: Addd option to set callbackUrl as external feat: Added option to set callbackUrl as external Oct 23, 2023
@zoey-kaiser zoey-kaiser merged commit 87e448a into main Oct 23, 2023
3 checks passed
@zoey-kaiser zoey-kaiser deleted the fix-local-hard-refresh branch October 23, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local provider causes hard refresh when logging in/out/refresh
2 participants