fix: navigateTo throws error on local provider
#540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoey-kaiser
changed the title
navigateTo throws error on local provider
|
Any thoughts in maybe making this optional/configurable? It causes a full refresh of the page and that's not really the expected behaviour when logging in / out. |
Thats a good point. Ill investigate it tomorrow! Thanks for bringing it up! |
|
Good! I will create an issue just to keep track of it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #429
Due to the fact that we compose full URLs, when redirecting in the local provider,
navigateTothrows an error, as it seems like we redirect to external URLs, as we use full urls and not relative ones.The easiest fix is to allow the local provider to redirect externally, which is what this PR does.
Checklist:
#)