Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added cookie provider #495

Closed

Conversation

shainegordon
Copy link

Closes #494 .

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • manually checked my feature / checking not applicable
  • wrote tests / testing not applicable
  • attached screenshots / screenshot not applicable

@zoey-kaiser
Copy link
Member

Wow! This is a huge contribution! Thank you @shainegordon! ❤️

Ill approve the workflow and have our CI do an initial runthrough. Once the CI is satisfied I will pass this along for a proper review and we can then look to merge it!

@zoey-kaiser zoey-kaiser requested a review from BracketJohn July 26, 2023 14:25
@shainegordon
Copy link
Author

shainegordon commented Jul 26, 2023 via email

@zoey-kaiser
Copy link
Member

Unfortunately I will only be able to look at this after the 12th August, as

Not a problem at all! Ping me once your back and I can relook at it!

I swear that I looked for a test folder, and didn’t see any, obviously I

We use the playground as our test environment. Both playgrounds are started and it checks if any issues occur! But in your PR its only a simple linting issue!

@shainegordon
Copy link
Author

@zoey-kaiser I have gone ahead and fixed the linting issues.

I've also added a GitHub Action job "test-playground-cookie" to align with the others

@zoey-kaiser
Copy link
Member

@zoey-kaiser I have gone ahead and fixed the linting issues.

Perfect! I am letting the CI run once again and if everything goes well, I will do some testing! We also need some documentation to the new provider, do you feel comfortable adding it in /docs?

@shainegordon
Copy link
Author

shainegordon commented Aug 15, 2023

@zoey-kaiser I have gone ahead and fixed the linting issues.

Perfect! I am letting the CI run once again and if everything goes well, I will do some testing! We also need some documentation to the new provider, do you feel comfortable adding it in /docs?

Sure, I will see if I can update the docs sometime this week.

I just got back from leave, so have a bit of catching up to do for the day job 😄

@yabe-diverta
Copy link

any updates?

@AlejandroAkbal
Copy link

EAGERLY awaiting this to be merged

@zoey-kaiser
Copy link
Member

Hi everyone!

I want to merge this and begin testing it as soon as we release 0.6.0! I don't want to cram this into that release, as we have already done a lot of testing on it and introducing this, may break some things.
I hope we can release 0.6.0 next week and then I can do a new beta release with this provider!

Hang tight. I have not forgotten about you ♥️

@benjipott benjipott mentioned this pull request Nov 9, 2023
4 tasks
@benjipott
Copy link

Hi all, i added options to local provider to prevent adding many provider workflows. you can see all here.
IMHO, it's better to add simple options to the config file.
#564

@zoey-kaiser
Copy link
Member

zoey-kaiser commented Dec 4, 2023

Closed in favour of #564

@zoey-kaiser zoey-kaiser closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Provider: Cookie
5 participants