Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: protected route redirect overwrite per page #424

Merged
merged 13 commits into from
Sep 23, 2023
Merged

feat: protected route redirect overwrite per page #424

merged 13 commits into from
Sep 23, 2023

Conversation

LouisHaftmann
Copy link
Contributor

Adds a navigateUnauthenticatedTo option to definePageMeta() to allow for overwriting the default behavior of redirecting to the login page

BracketJohn
BracketJohn reviewed Jun 17, 2023
View reviewed changes
Copy link
Contributor

@BracketJohn BracketJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to get around to this - was quite busy with my day job.

I like the feature - would just be good to also add some documentation here, same as in other PR!

If you add aome we should be ready to go, thanks!

BracketJohn
BracketJohn reviewed Jun 26, 2023
View reviewed changes
Copy link
Contributor

@BracketJohn BracketJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in other PR of yours: Please move your docs-changes to the v0.6 docs, thanks!

src/runtime/middleware/auth.ts Outdated Show resolved Hide resolved
@zoey-kaiser zoey-kaiser self-requested a review July 26, 2023 14:26
zoey-kaiser
zoey-kaiser previously approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@zoey-kaiser zoey-kaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

valiafetisov
valiafetisov reviewed Aug 10, 2023
View reviewed changes
src/runtime/middleware/auth.ts Outdated Show resolved Hide resolved
src/runtime/middleware/auth.ts Show resolved Hide resolved
@zoey-kaiser zoey-kaiser merged commit 57c1431 into sidebase:main Sep 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoey-kaiser zoey-kaiser zoey-kaiser approved these changes

@BracketJohn BracketJohn Awaiting requested review from BracketJohn

@valiafetisov valiafetisov Awaiting requested review from valiafetisov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LouisHaftmann @valiafetisov @BracketJohn @zoey-kaiser